Better prod fallback #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| * @returns application domain such as topcoder-dev.com | ||
| */ | ||
| static getAppDomain( | ||
| configService?: { get<T = any>(key: string): T | undefined }, |
There was a problem hiding this comment.
[maintainability]
The configService parameter is defined but never used in the function. Consider removing it if it's not needed, or utilize it to fetch configuration values if intended.
| static getAppDomain( | ||
| configService?: { get<T = any>(key: string): T | undefined }, | ||
| ): string { | ||
| const envDomain = process.env.APP_DOMAIN; |
There was a problem hiding this comment.
[design]
Accessing environment variables directly within the function can make testing more difficult. Consider passing the environment variables as parameters or using dependency injection to improve testability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOTFIX: https://topcoder.atlassian.net/browse/PS-439