Delete user functionality (PM-3158) #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| API_VERSION: process.env.API_VERSION || 'v6', | ||
| AUTH_SECRET: process.env.AUTH_SECRET || 'mysecret', | ||
| VALID_ISSUERS: process.env.VALID_ISSUERS || '["https://api.topcoder-dev.com", "https://api.topcoder.com", "https://topcoder-dev.auth0.com/", "https://auth.topcoder-dev.com/"]', | ||
| IDENTITY_DB_URL: process.env.IDENTITY_DB_URL, |
There was a problem hiding this comment.
[❗❗ correctness]
The IDENTITY_DB_URL is added without a default value. Ensure that this environment variable is always set in all environments to prevent potential runtime errors.
| ALL: process.env.SCOPE_MEMBERS_ALL || 'all:user_profiles' | ||
| } | ||
| }, | ||
| DELETE_USER_SCOPE: process.env.SCOPE_DELETE_USER || 'delete:user', |
There was a problem hiding this comment.
[❗❗ security]
The DELETE_USER_SCOPE is introduced without a clear indication of its usage in the system. Ensure that this scope is properly validated and enforced in the application logic to prevent unauthorized access.
| MAILCHIMP: { | ||
| API_KEY: process.env.MAILCHIMP_API_KEY, | ||
| SERVER_PREFIX: process.env.MAILCHIMP_SERVER_PREFIX, | ||
| LIST_FETCH_COUNT: process.env.MAILCHIMP_LIST_FETCH_COUNT ? Number(process.env.MAILCHIMP_LIST_FETCH_COUNT) : 1000 |
There was a problem hiding this comment.
[performance]
Consider validating the MAILCHIMP_LIST_FETCH_COUNT to ensure it is within acceptable limits, as setting it too high could lead to performance issues or API rate limits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PM-3158