fix(PM-3317): included talent manager to check for profile downloadable role#21
Merged
hentrymartin merged 2 commits intodevelopfrom Jan 12, 2026
Merged
fix(PM-3317): included talent manager to check for profile downloadable role#21hentrymartin merged 2 commits intodevelopfrom
hentrymartin merged 2 commits intodevelopfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| */ | ||
| const ADMIN_ROLES = ['administrator', 'admin'] | ||
| const PM_ROLES = ['project manager'] | ||
| const PROFILE_DOWNLOAD_ROLES = ['project manager', 'Talent Manager'] |
There was a problem hiding this comment.
[💡 maintainability]
Consider renaming PROFILE_DOWNLOAD_ROLES to PROFILE_ACCESS_ROLES to better reflect the purpose of the roles, which is to access and download profiles. This can improve clarity and maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?