PM-3532 Return all rows for privilged user#54
Merged
himaniraghav3 merged 2 commits intodevelopfrom Feb 4, 2026
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| const personalizationFilter = canReadPrivate | ||
| ? { private: true } | ||
| ? {} |
There was a problem hiding this comment.
[❗❗ security]
The change from { private: true } to {} in the personalizationFilter means that all personalization records will be queried without any filter when canReadPrivate is true. Ensure this is the intended behavior, as it could potentially expose more data than necessary.
| traits: { | ||
| traitId: 'personalization', | ||
| data: [collectInfo] | ||
| data: _.map(traitData.personalization, t => ({ |
There was a problem hiding this comment.
[design]
The use of _.map here creates an array of objects where each object has a single key-value pair. This structure may not be optimal if the intention is to have a single object with multiple key-value pairs. Consider verifying if this structure is intended and if not, adjust the logic to accumulate key-value pairs into a single object.
kkartunov
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should return all records for self/autocomplete and public records for others
Missed this earlier