Skip to content

Pm 1496 Show other payment type in opportunity listing #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
himaniraghav3 merged 2 commits into from
Jul 24, 2025
Merged

Pm 1496 Show other payment type in opportunity listing #1154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a38cb6
Merge branch 'dev' into PM-1496
himaniraghav3 Jul 24, 2025
02e5b80
PM-1496 Show other payment type in list
himaniraghav3 Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,16 @@ const CopilotOpportunityDetails: FC<{}> = () => {
<span className={styles.infoValue}>{opportunity?.tzRestrictions}</span>
</div>
</div>
<div className={styles.infoColumn}>
<IconOutline.CashIcon className={styles.icon} />
<div className={styles.infoText}>
<span className={styles.infoHeading}>Payment</span>
<span className={styles.infoValue}>
{opportunity?.paymentType === 'standard'
? opportunity.paymentType : opportunity?.otherPaymentType}
</span>
</div>
</div>
</div>
{
initialized && (
Expand Down
8 changes: 7 additions & 1 deletion src/apps/copilots/src/pages/copilot-opportunity-list/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,13 @@ const tableColumns: TableColumn<CopilotOpportunity>[] = [
{
label: 'Payment',
propertyName: 'paymentType',
type: 'text',
renderer: (copilotOpportunity: CopilotOpportunity) => (
<div>
Copy link

@github-actions github-actions bot Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a more descriptive variable name for copilotOpportunity in the renderer function to improve readability, especially if the function grows in complexity.

{copilotOpportunity.paymentType === 'standard'
Copy link

@github-actions github-actions bot Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditional logic could be simplified using a ternary operator directly in the JSX expression. Consider using: {copilotOpportunity.paymentType === 'standard' ? copilotOpportunity.paymentType : copilotOpportunity.otherPaymentType}.

? copilotOpportunity.paymentType : copilotOpportunity.otherPaymentType}
</div>
),
type: 'element',
},
]

Expand Down