Wallet and review phase display issue fixes #1280
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return false | ||
| } | ||
|
|
||
| if (fragment === 'iterative' && hasExplicitReviewPhase) { |
There was a problem hiding this comment.
[correctness]
The check for fragment === 'iterative' is case-sensitive. If there is any chance that fragment could be in a different case (e.g., 'Iterative'), consider normalizing the case of fragment before comparison to ensure consistency.
| ) | ||
| } | ||
| }, [walletDetails]) | ||
| const balanceSum = useMemo( |
There was a problem hiding this comment.
[performance]
Using useMemo here is appropriate for performance optimization, but ensure that walletDetails.account.balances is not mutated elsewhere in the component lifecycle, as it could lead to stale values being used.
| if (typeof error === 'string') { | ||
| errorMessage = error | ||
| } else if (error && typeof error === 'object' && 'message' in error) { | ||
| errorMessage = (error as Error).message || errorMessage |
There was a problem hiding this comment.
[correctness]
The error handling logic assumes that the error object has a message property. Consider adding a type guard or validation to ensure this property exists to avoid potential runtime errors.
| export interface Response<T> { | ||
| data?: Readonly<T> | ||
| error?: Readonly<string> | ||
| error?: Readonly<Error> | string |
There was a problem hiding this comment.
[correctness]
Changing error to Readonly<Error> | string allows for more flexibility, but ensure that all parts of the code handling this error property can correctly process both Error objects and strings. This change might require additional checks or transformations where error is used to avoid runtime issues.
Refactored the HomeTab in wallet to keep under lint complexity complaints and also fixed how it handles errors that are objects, not strings, which was causing a problem loading the page.
Also includes a fix to the review UI where a recent fix caused reviews to not show in certain cases.