Feat/v6 #1283
Merged
Feat/v6 #1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| <a | ||
| href={ | ||
| `${EnvironmentConfig.ADMIN.ONLINE_REVIEW_URL}/actions/ViewProjectDetails?pid=${props.challenge.legacyId}` /* eslint-disable-line max-len */ | ||
| `${EnvironmentConfig.ADMIN.REVIEW_UI_URL}/=${props.challenge.id}` /* eslint-disable-line max-len */ |
There was a problem hiding this comment.
[❗❗ correctness]
The URL structure seems incorrect. The = character after REVIEW_UI_URL appears misplaced and might lead to an invalid URL. Ensure the URL is constructed correctly to avoid broken links.
| }) | ||
| return map | ||
| }, [props.submissions]) | ||
| const handleSubmissionDownload = useCallback((submissionId: string) => { |
There was a problem hiding this comment.
[performance]
The useCallback dependency array includes submissionsById, which is derived from props.submissions. Ensure that props.submissions is stable or memoized to prevent unnecessary recalculations of handleSubmissionDownload.
| const targetUrl = submission.url?.trim() | ||
| if (targetUrl) { | ||
| if (typeof window !== 'undefined') { | ||
| const openedWindow = window.open(targetUrl, '_blank', 'noopener,noreferrer') |
There was a problem hiding this comment.
[security]
When opening a new window with window.open, consider checking if targetUrl is a valid URL to prevent potential issues with malformed URLs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up some remaining OR / -v6 links and add in the ability to redirect to URL submissions for TG.