Skip to content

PM-2554 Fix search in wallet admin #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

PM-2554 Fix search in wallet admin #1293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/apps/wallet-admin/src/lib/services/wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ export async function getPayments(limit: number, offset: number, filters: Record
}

if (filters.winnerIds && filters.winnerIds.length > 0) {
payload.winnerIds = filters.winnerIds
payload.winnerIds = filters.winnerIds.map(id => id.toString())
Copy link

@github-actions github-actions bot Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
Converting winnerIds to strings using map(id => id.toString()) is a good approach to ensure consistency in data types. However, ensure that filters.winnerIds is always an array of numbers or strings to avoid unexpected behavior. Consider adding validation earlier in the data flow if this assumption might not hold.

}

const body = JSON.stringify(payload)
Expand Down