Skip to content

update styling form md renderer #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
Merged

update styling form md renderer #1338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/apps/review/src/pages/reviews/components/AiModelModal/AiModelModal.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@
}
}

.mdContainer {
& > * {
all: revert-layer;
Copy link

@github-actions github-actions bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
Using all: revert-layer; can have broad effects by resetting all CSS properties to their inherited values, which might lead to unexpected styling issues. Ensure this is the intended behavior and test thoroughly across different browsers and components.

}
}

.modelIcon {
width: 60px;
height: 60px;
Expand Down
2 changes: 1 addition & 1 deletion src/apps/review/src/pages/reviews/components/AiModelModal/AiModelModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const AiModelModal: FC<AiModelModalProps> = props => (
</div>

<p className={styles.modelDescription}>
<MarkdownReview value={props.model.description} />
<MarkdownReview className={styles.mdContainer} value={props.model.description} />
</p>
</div>
</BaseModal>
Expand Down
8 changes: 7 additions & 1 deletion src/apps/review/src/pages/reviews/components/ScorecardHeader/ScorecardHeader.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@
gap: $sp-4;
}

.mdContainer {
& > * {
all: revert-layer;
Copy link

@github-actions github-actions bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
Using all: revert-layer; can have unintended side effects by resetting styles from other layers. Ensure this is the intended behavior and that it doesn't interfere with other styles applied to the children of .mdContainer.

}
}

.workflowIcon {
width: 60px;
height: 60px;
Expand Down Expand Up @@ -105,7 +111,7 @@
height: 20px;
stroke: #0a0a0a;
}

&.iconFile {
path {
fill: #0A0A0A;
Expand Down
5 changes: 4 additions & 1 deletion src/apps/review/src/pages/reviews/components/ScorecardHeader/ScorecardHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,10 @@ const ScorecardHeader: FC = () => {
</div>
</div>
<p className={styles.workflowDescription}>
<MarkdownReview value={workflow.description} />
<MarkdownReview
className={styles.mdContainer}
value={workflow.description}
/>
</p>
{/* <div className={styles.workflowFileLink}>
<a href={workflow.defUrl}>
Expand Down
Loading