Add delete user functionality to system-admin app / fix checkpoint screener #1363
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| @import '@libs/ui/styles/includes'; | ||
|
|
||
| .container { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: $sp-4; | ||
| } | ||
|
|
||
| .description { | ||
| white-space: pre-line; | ||
| } | ||
|
|
||
| .actions { | ||
| display: flex; | ||
| justify-content: flex-end; | ||
| gap: $sp-3; | ||
| margin-top: $sp-4; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| import { ChangeEvent, FC, useCallback, useEffect, useState } from 'react' | ||
| import classNames from 'classnames' | ||
|
|
||
| import { BaseModal, Button, InputText } from '~/libs/ui' | ||
|
|
||
| import { UserInfo } from '../../models' | ||
|
|
||
| import styles from './DialogDeleteUser.module.scss' | ||
|
|
||
| interface Props { | ||
| className?: string | ||
| open: boolean | ||
| setOpen: (isOpen: boolean) => void | ||
| userInfo: UserInfo | ||
| isLoading?: boolean | ||
| onDelete: (ticketUrl: string) => void | ||
| } | ||
|
|
||
| export const DialogDeleteUser: FC<Props> = (props: Props) => { | ||
| const [ticketUrl, setTicketUrl] = useState('') | ||
| const [error, setError] = useState('') | ||
|
|
||
| useEffect(() => { | ||
| if (props.open) { | ||
| setTicketUrl('') | ||
| setError('') | ||
| } | ||
| }, [props.open]) | ||
|
|
||
| const handleClose = useCallback(() => { | ||
| if (!props.isLoading) { | ||
| props.setOpen(false) | ||
| } | ||
| }, [props.isLoading, props.setOpen]) | ||
|
|
||
| const handleConfirm = useCallback(() => { | ||
| if (!ticketUrl.trim()) { | ||
| setError('Delete ticket URL is required') | ||
| return | ||
| } | ||
|
|
||
| setError('') | ||
| props.onDelete(ticketUrl.trim()) | ||
|
There was a problem hiding this comment. [❗❗ |
||
| }, [props, ticketUrl]) | ||
|
|
||
| const handleTicketUrlChange = useCallback( | ||
| (event: ChangeEvent<HTMLInputElement>) => { | ||
| if (error) { | ||
| setError('') | ||
| } | ||
|
|
||
| setTicketUrl(event.target.value) | ||
| }, | ||
| [error], | ||
| ) | ||
|
|
||
| const description | ||
|
There was a problem hiding this comment. [💡 |
||
| = `Are you sure you want to DELETE user ${props.userInfo.handle} with email address ${props.userInfo.email}. ` | ||
| + 'If you are sure, please enter the associated delete request ticket URL below' | ||
|
|
||
| return ( | ||
| <BaseModal | ||
| allowBodyScroll | ||
| blockScroll | ||
| title={`Delete ${props.userInfo.handle}`} | ||
| onClose={handleClose} | ||
| open={props.open} | ||
| focusTrapped={false} | ||
| > | ||
| <div className={classNames(styles.container, props.className)}> | ||
| <p className={styles.description}>{description}</p> | ||
| <InputText | ||
| name='ticketUrl' | ||
| label='Delete request ticket URL' | ||
| placeholder='https://' | ||
| type='text' | ||
| value={ticketUrl} | ||
| error={error} | ||
| onChange={handleTicketUrlChange} | ||
| disabled={props.isLoading} | ||
| /> | ||
|
|
||
| <div className={styles.actions}> | ||
| <Button | ||
| secondary | ||
| size='lg' | ||
| onClick={handleClose} | ||
| disabled={props.isLoading} | ||
| > | ||
| Cancel | ||
| </Button> | ||
| <Button | ||
| primary | ||
| variant='danger' | ||
| size='lg' | ||
| onClick={handleConfirm} | ||
| disabled={props.isLoading} | ||
| > | ||
| DELETE | ||
| </Button> | ||
| </div> | ||
| </div> | ||
| </BaseModal> | ||
| ) | ||
| } | ||
|
|
||
| export default DialogDeleteUser | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export { DialogDeleteUser } from './DialogDeleteUser' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,7 +57,7 @@ | |
| } | ||
|
|
||
| .blockColumnAction { | ||
| width: 320px; | ||
|
|
||
| @include ltelg { | ||
| width: 60px; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[💡
readability]Consider using a more specific error message to guide the user, such as 'Please enter a valid delete ticket URL.' This can improve user experience by providing clearer instructions.