Skip to content

Potential fix for code scanning alert no. 71: Incomplete string escaping or encoding #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkartunov merged 4 commits into from
Dec 12, 2025
Merged

Potential fix for code scanning alert no. 71: Incomplete string escaping or encoding #1376

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f4c928
Potential fix for code scanning alert no. 71: Incomplete string escap…
kkartunov Dec 12, 2025
020c230
Initial plan
Copilot Dec 12, 2025
6bd27a9
Fix ESLint semicolon errors in metadataMatching.ts
Copilot Dec 12, 2025
01a64b8
Merge pull request #1378 from topcoder-platform/copilot/sub-pr-1376
kkartunov Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/apps/review/src/lib/utils/metadataMatching.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,14 @@ export function findMetadataPhaseMatch(
return { source: 'stringExact' }
}

const escapedTarget = escapeRegexLiteral(target)
.replace(/ /g, '\\ ')
const sepInsensitive = new RegExp(`\\b${escapedTarget.replace(/\\ /g, '[-_\\s]+')}\\b`)
// Replace all sequences of space, underscore, or hyphen in the target with a placeholder
const WORDSEP_PLACEHOLDER = '__WORDSEP__'
Copy link

@github-actions github-actions bot Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[💡 style]
Consider adding semicolons at the end of statements to maintain consistency with the rest of the codebase, which uses semicolons. This can help prevent potential issues with automatic semicolon insertion.

const sepPattern = /[ \-_]+/g
const targetWithPlaceholder = target.replace(sepPattern, WORDSEP_PLACEHOLDER)
// Properly escape ALL regex metacharacters (including backslash), leaving the placeholder intact
const escapedTarget = escapeRegexLiteral(targetWithPlaceholder)
.replace(new RegExp(escapeRegexLiteral(WORDSEP_PLACEHOLDER), 'g'), '[-_\\s]+')
Copy link

@github-actions github-actions bot Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
The replacement pattern [-_\s]+ is used to match sequences of separators. Ensure that this pattern aligns with the intended behavior and that no additional separators need to be considered. If the pattern should be more flexible, consider documenting the expected input format.

const sepInsensitive = new RegExp(`\\b${escapedTarget}\\b`)
if (sepInsensitive.test(normalizedMetadata)) {
return { source: 'stringBoundary' }
}
Expand Down
Loading