Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 12, 2025

Related JIRA Ticket:

https://topcoder.atlassian.net/browse/

What's in this PR?

Removed semicolons from metadataMatching.ts to comply with the project's ESLint semi: never rule. The previous security fix introduced 5 semicolons that violated the codebase style convention.

Changes

  • Removed semicolons from constant declarations and chained method calls in the findMetadataPhaseMatch function (lines 116-122)
  • No functional changes to the regex escaping logic introduced in the security fix
// Before (with semicolons - ESLint error)
const WORDSEP_PLACEHOLDER = '__WORDSEP__';
const sepPattern = /[ \-_]+/g;

// After (no semicolons - ESLint compliant)
const WORDSEP_PLACEHOLDER = '__WORDSEP__'
const sepPattern = /[ \-_]+/g

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: kkartunov <5585002+kkartunov@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix incomplete string escaping in code scanning alert Fix ESLint semicolon violations in metadataMatching.ts Dec 12, 2025
Copilot AI requested a review from kkartunov December 12, 2025 07:05
@kkartunov kkartunov marked this pull request as ready for review December 12, 2025 07:08
@kkartunov kkartunov requested a review from jmgasper as a code owner December 12, 2025 07:08
@kkartunov kkartunov merged commit 01a64b8 into alert-autofix-71 Dec 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants