PM-4070 Change completeness text for admin#1503
Merged
himaniraghav3 merged 3 commits intodevfrom Mar 3, 2026
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/apps/profiles/src/member-profile/page-layout/ProfilePageLayout.tsx
Outdated
Show resolved
Hide resolved
src/apps/profiles/src/member-profile/profile-completeness/ProfileCompleteness.tsx
Outdated
Show resolved
Hide resolved
| interface ProfileCompletenessProps { | ||
| profile: UserProfile | ||
| authProfile: UserProfile | undefined | ||
| isAdminOrTM: boolean |
There was a problem hiding this comment.
[❗❗ correctness]
The prop name change from canSeeProfileCompleteness to isAdminOrTM alters the semantics of the code. Ensure that all usages of this prop throughout the codebase are updated accordingly, as this could lead to logic errors if any references are missed.
| interface ProfileCompletenessProps { | ||
| profile: UserProfile | ||
| authProfile: UserProfile | undefined | ||
| isAdminOrTM?: boolean |
There was a problem hiding this comment.
[❗❗ correctness]
Changing isAdminOrTM from a required to an optional prop could lead to potential issues if the component logic assumes it is always defined. Ensure that the component handles the case where isAdminOrTM is undefined appropriately, especially in conditional rendering.
vas3a
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-4070
What's in this PR?