Conversation
What was broken When users selected Immediately for the challenge start mode, saving or launching the challenge caused the reopened schedule view to show Scheduled instead. Root cause The schedule editor did not persist the selected start-mode radio anywhere durable. After reloading a saved challenge, the UI only saw a concrete startDate and inferred Scheduled from that value alone. What was changed Persisted the selected challenge start mode in challenge metadata under challengeStartMode. Updated ChallengeScheduleSection to restore the radio state from that metadata before falling back to startDate. Kept the metadata in sync when users switch between Immediately and Scheduled. Updated the challenge editor README to document the persisted behavior. Any added/updated tests Added a regression test covering a saved challenge with a concrete startDate plus persisted immediate-mode metadata. Updated the schedule section component tests to assert the metadata value changes when the start mode changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
When users selected Immediately for the challenge start mode, saving or launching the challenge caused the reopened schedule view to show Scheduled instead.
Root cause
The schedule editor did not persist the selected start-mode radio anywhere durable. After reloading a saved challenge, the UI only saw a concrete startDate and inferred Scheduled from that value alone.
What was changed
Persisted the selected challenge start mode in challenge metadata under challengeStartMode.
Updated ChallengeScheduleSection to restore the radio state from that metadata before falling back to startDate.
Kept the metadata in sync when users switch between Immediately and Scheduled.
Updated the challenge editor README to document the persisted behavior.
Any added/updated tests
Added a regression test covering a saved challenge with a concrete startDate plus persisted immediate-mode metadata.
Updated the schedule section component tests to assert the metadata value changes when the start mode changes.