Conversation
What was broken The previous PM-4840 fix restored persisted copilot and reviewer assignments during refresh hydration, but saving an existing draft could still reset the editor from a sparse challenge payload that omitted resource-backed reviewer members. That left refreshed or reopened drafts showing blank reviewer assignments again even though the resources were already saved. Root cause (if identifiable) The post-save reset path rebuilt form state from the `patchChallenge` response and only reapplied single-member assignments from the in-memory hook state. When the hook cache did not already contain the saved reviewer resources, manual reviewer members were dropped from the form state until a later fetch happened. What was changed The draft save flow now reloads persisted resources and resource roles before resetting the form, then reapplies the shared copilot and manual-reviewer hydration logic to the saved draft state. This keeps saved reviewer assignments attached immediately after save and when the draft is reopened. Any added/updated tests Added ChallengeEditorForm coverage for saving a draft when the hook resource cache is empty but persisted reviewer assignments exist in freshly fetched resources.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The previous PM-4840 fix restored persisted copilot and reviewer assignments during refresh hydration, but saving an existing draft could still reset the editor from a sparse challenge payload that omitted resource-backed reviewer members. That left refreshed or reopened drafts showing blank reviewer assignments again even though the resources were already saved.
Root cause (if identifiable)
The post-save reset path rebuilt form state from the
patchChallengeresponse and only reapplied single-member assignments from the in-memory hook state. When the hook cache did not already contain the saved reviewer resources, manual reviewer members were dropped from the form state until a later fetch happened.What was changed
The draft save flow now reloads persisted resources and resource roles before resetting the form, then reapplies the shared copilot and manual-reviewer hydration logic to the saved draft state. This keeps saved reviewer assignments attached immediately after save and when the draft is reopened.
Any added/updated tests
Added ChallengeEditorForm coverage for saving a draft when the hook resource cache is empty but persisted reviewer assignments exist in freshly fetched resources.