Conversation
What was broken Marathon matches and development challenges were always treated as rated from the work app because the challenge editor did not expose an opt-out control. Root cause (if identifiable) Member API already honors challenge metadata named isRated with value false, but platform-ui never let users set or clear that metadata during challenge setup. What was changed Added a Rate this challenge checkbox in Advanced Options for marathon match and development challenge forms. The checkbox defaults to checked, writes metadata isRated=false when unchecked, and removes that metadata when checked again so rated remains the default. Any added/updated tests Added RateChallengeField tests covering the default checked state, writing isRated=false when unchecked, and removing the metadata when rechecked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Marathon matches and development challenges were always treated as rated from the work app because the challenge editor did not expose an opt-out control.
Root cause (if identifiable)
Member API already honors challenge metadata named isRated with value false, but platform-ui never let users set or clear that metadata during challenge setup.
What was changed
Added a Rate this challenge checkbox in Advanced Options for marathon match and development challenge forms. The checkbox defaults to checked, writes metadata isRated=false when unchecked, and removes that metadata when checked again so rated remains the default.
Any added/updated tests
Added RateChallengeField tests covering the default checked state, writing isRated=false when unchecked, and removing the metadata when rechecked.