Skip to content

PM-5104: Add TG reprocess confirmation#1864

Merged
jmgasper merged 1 commit into
devfrom
PM-5104
May 20, 2026
Merged

PM-5104: Add TG reprocess confirmation#1864
jmgasper merged 1 commit into
devfrom
PM-5104

Conversation

@jmgasper
Copy link
Copy Markdown
Collaborator

What was broken
The Topgear submission reprocess icon in the review app sent the reprocess request immediately when clicked.

Root cause
The click handler directly called the Topgear reprocess service without a confirmation step.

What was changed
Added a confirmation dialog that asks whether to reprocess the selected Topgear submission, with Yes continuing the reprocess request and No closing the dialog.

Any added/updated tests
Added a focused TabContentSubmissions component test covering that the dialog opens, No does not reprocess, and Yes calls the reprocess service.

Validation run:

  • yarn lint passed.
  • yarn test:no-watch src/apps/review/src/lib/components/ChallengeDetailsContent/TabContentSubmissions.spec.tsx --runInBand passed.
  • yarn run build passed with existing warnings.
  • yarn test:no-watch --runInBand was run and still fails in unrelated work/wallet-admin specs: ChallengeEditorForm.spec.tsx cannot resolve ~/libs/core, wallet.spec.ts cannot resolve ~/apps/work/src/lib/services/challenges.service, and PaymentView.spec.tsx expects a task challenge URL but receives the project URL.

What was broken
The Topgear submission reprocess icon in the review app sent the reprocess request immediately when clicked.

Root cause
The click handler directly called the Topgear reprocess service without a confirmation step.

What was changed
Added a confirmation dialog that asks whether to reprocess the selected Topgear submission, with Yes continuing the reprocess request and No closing the dialog.

Any added/updated tests
Added a focused TabContentSubmissions component test covering that the dialog opens, No does not reprocess, and Yes calls the reprocess service.
@jmgasper jmgasper requested a review from kkartunov as a code owner May 20, 2026 03:05
@jmgasper jmgasper merged commit dd7aa5a into dev May 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant