Conversation
What was broken The Work app submissions table could show an older raw Marathon Match score while community-app showed the updated relative provisional score. Root cause The Work app score helper returned the first matching Review API summation, and legacy nested scores were preferred before summations, so later relative-score rewrites could be ignored. What was changed Marathon provisional and system score helpers now pick the latest valid matching review summation by timestamp and use legacy nested scores only as a fallback. Any added/updated tests Added regression coverage for provisional and system scores where a later relative summation must override a stale raw score.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The Work app submissions table could show an older raw Marathon Match score while community-app showed the updated relative provisional score.
Root cause
The Work app score helper returned the first matching Review API summation, and legacy nested scores were preferred before summations, so later relative-score rewrites could be ignored.
What was changed
Marathon provisional and system score helpers now pick the latest valid matching review summation by timestamp and use legacy nested scores only as a fallback.
Any added/updated tests
Added regression coverage for provisional and system scores where a later relative summation must override a stale raw score.
Validation run:
The full yarn test:no-watch command was also run. It still fails in unrelated pre-existing specs under wallet-admin and ChallengeEditorForm module resolution; the PM-5112 targeted tests pass.