Skip to content

PM-5113: Use marathon aggregate review scores#1867

Merged
jmgasper merged 1 commit into
devfrom
PM-5113
May 21, 2026
Merged

PM-5113: Use marathon aggregate review scores#1867
jmgasper merged 1 commit into
devfrom
PM-5113

Conversation

@jmgasper
Copy link
Copy Markdown
Collaborator

What was broken
Marathon Match review rows displayed scorecard-derived review scores, so submitters could see 0.00 and a Fail result after winners were announced even when review summations had the final aggregate score.

Root cause
The review app's shared review table helpers preferred per-review scorecard averages over submission aggregate scores, and the score cell always linked through the scorecard path. Marathon Match system reviews do not have a scorecard to open.

What was changed
Added Marathon Match challenge detection in the review app and routed review tables to prefer review summation aggregate scores for Marathon Match submissions. The Review Score and Score cells now display the aggregate score as plain text for Marathon Match rows, and pass/fail resolution can use the aggregate score before scorecard averages.

Any added/updated tests
Added tests for Marathon Match challenge detection, aggregate-score pass/fail resolution, and aggregate score rendering without a scorecard link.

Validation:

  • yarn lint passed.
  • yarn test:no-watch --runTestsByPath src/apps/review/src/lib/components/common/reviewResult.spec.ts src/apps/review/src/lib/components/common/TableColumnRenderers.spec.tsx src/apps/review/src/lib/utils/challenge.spec.ts passed.
  • yarn run build passed with existing CSS order and lint warnings.
  • yarn test:no-watch was run; the new tests passed, but the full suite failed in unrelated existing wallet-admin and work app tests.

What was broken
Marathon Match review rows displayed scorecard-derived review scores, so submitters could see 0.00 and a Fail result after winners were announced even when review summations had the final aggregate score.

Root cause
The review app's shared review table helpers preferred per-review scorecard averages over submission aggregate scores, and the score cell always linked through the scorecard path. Marathon Match system reviews do not have a scorecard to open.

What was changed
Added Marathon Match challenge detection in the review app and routed review tables to prefer review summation aggregate scores for Marathon Match submissions. The Review Score and Score cells now display the aggregate score as plain text for Marathon Match rows, and pass/fail resolution can use the aggregate score before scorecard averages.

Any added/updated tests
Added tests for Marathon Match challenge detection, aggregate-score pass/fail resolution, and aggregate score rendering without a scorecard link.
@jmgasper jmgasper requested a review from kkartunov as a code owner May 21, 2026 00:29
@jmgasper jmgasper merged commit 86c77b5 into dev May 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant