Conversation
What was broken Challenge prize amount inputs could lose focus after a digit was entered, interrupting continuous typing in the Work Manager challenge editor. Root cause Prize row updates are driven through React Hook Form as nested prize values change. The active placement-prize input was not tracked or restored when those controlled updates re-rendered the row. What was changed Track the active placement-prize row in ChallengePrizesField and allow PrizeInput to restore focus and caret position for that active row after value updates. Updated the challenge editor documentation for the focus-preservation behavior. Any added/updated tests Updated the ChallengePrizesField test to exercise the real PrizeInput and added coverage for continuously typing multiple digits into an empty prize input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Challenge prize amount inputs could lose focus after a digit was entered, interrupting continuous typing in the Work Manager challenge editor.
Root cause
Prize row updates are driven through React Hook Form as nested prize values change. The active placement-prize input was not tracked or restored when those controlled updates re-rendered the row.
What was changed
Track the active placement-prize row in ChallengePrizesField and allow PrizeInput to restore focus and caret position for that active row after value updates. Updated the challenge editor documentation for the focus-preservation behavior.
Any added/updated tests
Updated the ChallengePrizesField test to exercise the real PrizeInput and added coverage for continuously typing multiple digits into an empty prize input.
Validation
Note: yarn test:no-watch was also run for the full repo suite and currently fails in unrelated wallet-admin, wallet, work payment, and engagements tests due existing module-resolution or mock/export issues outside this PM-5116 change.