Skip to content

PM-4836: Place review action on reviewer row#1884

Merged
jmgasper merged 1 commit into
devfrom
PM-4836
May 26, 2026
Merged

PM-4836: Place review action on reviewer row#1884
jmgasper merged 1 commit into
devfrom
PM-4836

Conversation

@jmgasper
Copy link
Copy Markdown
Collaborator

What was broken

The review table rendered the current reviewer action only on the first reviewer row for a submission. When a copilot reviewer was the second reviewer, Complete Review appeared beside the other reviewer.

Root cause

The actions cell looked up the current user's review across the whole submission while the table only rendered actions for the first flattened reviewer row.

What was changed

Reviewer-owned actions now resolve against the flattened row's reviewer index, so Complete Review, Review Complete, and Reopen Review render on the row for the matching reviewer resource. Submission-level actions still render only on the first row to avoid duplicates.

Any added/updated tests

Added regression coverage for a two-reviewer row set where the current reviewer is not first, ensuring only that reviewer row is action-eligible.

Validation run:

  • yarn lint passed.
  • yarn test:no-watch src/apps/review/src/lib/components/common/reviewResult.spec.ts passed.
  • yarn run build passed with existing warnings.
  • yarn test:no-watch was run and failed in unrelated wallet/work/engagement suites, including missing modules under wallet-admin and missing assignment utility exports in work engagement tests.

What was broken
The review table rendered the current reviewer action only on the first reviewer row for a submission. When a copilot reviewer was the second reviewer, Complete Review appeared beside the other reviewer.

Root cause
The actions cell looked up the current user's review across the whole submission while the table only rendered actions for the first flattened reviewer row.

What was changed
Reviewer-owned actions now resolve against the flattened row's reviewer index, so Complete Review, Review Complete, and Reopen Review render on the row for the matching reviewer resource. Submission-level actions still render only on the first row to avoid duplicates.

Any added/updated tests
Added regression coverage for a two-reviewer row set where the current reviewer is not first, ensuring only that reviewer row is action-eligible.
@jmgasper jmgasper marked this pull request as ready for review May 26, 2026 04:07
@jmgasper jmgasper requested a review from kkartunov as a code owner May 26, 2026 04:07
@jmgasper jmgasper merged commit 0e1c054 into dev May 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant