Conversation
What was broken The review table rendered the current reviewer action only on the first reviewer row for a submission. When a copilot reviewer was the second reviewer, Complete Review appeared beside the other reviewer. Root cause The actions cell looked up the current user's review across the whole submission while the table only rendered actions for the first flattened reviewer row. What was changed Reviewer-owned actions now resolve against the flattened row's reviewer index, so Complete Review, Review Complete, and Reopen Review render on the row for the matching reviewer resource. Submission-level actions still render only on the first row to avoid duplicates. Any added/updated tests Added regression coverage for a two-reviewer row set where the current reviewer is not first, ensuring only that reviewer row is action-eligible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The review table rendered the current reviewer action only on the first reviewer row for a submission. When a copilot reviewer was the second reviewer, Complete Review appeared beside the other reviewer.
Root cause
The actions cell looked up the current user's review across the whole submission while the table only rendered actions for the first flattened reviewer row.
What was changed
Reviewer-owned actions now resolve against the flattened row's reviewer index, so Complete Review, Review Complete, and Reopen Review render on the row for the matching reviewer resource. Submission-level actions still render only on the first row to avoid duplicates.
Any added/updated tests
Added regression coverage for a two-reviewer row set where the current reviewer is not first, ensuring only that reviewer row is action-eligible.
Validation run: