Conversation
What was broken The prior PM-5121 fix capped large reviewer counts, but the Work app could still freeze after the public review opportunity was closed and the Reviewer Count native stepper was decremented. Root cause (if identifiable) Closed-opportunity member selectors can leave blank additionalMemberIds slots registered in react-hook-form. When the count dropped, the trimming effect wrote those blank slots back during validation instead of unregistering them, allowing the form watcher to re-enter the same cleanup path. What was changed Unregistered additional member fields that are no longer visible when reviewer count shrinks, and only write/delete additional members when an actual assigned member value is being removed or preserved. Any added/updated tests Added HumanReviewTab coverage for decreasing reviewer count with a blank extra assignment slot and asserting no reviewer resource deletion is attempted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The prior PM-5121 fix capped large reviewer counts, but QA still reproduced the freeze by closing the public review opportunity and clicking the Reviewer Count down stepper.
Root cause (if identifiable)
Closed-opportunity member selectors can leave blank additionalMemberIds slots registered in react-hook-form. When the reviewer count dropped, the trimming effect treated those blank hidden slots as data to write back during validation, allowing the reviewer watcher cleanup path to re-enter repeatedly.
What was changed
Unregistered additional member fields that are no longer visible when reviewer count shrinks, and only write/delete additional members when an actual assigned member value is being removed or preserved.
Any added/updated tests
Added HumanReviewTab coverage for decreasing reviewer count with a blank extra assignment slot and asserting no reviewer resource deletion is attempted.
Validation: