Conversation
What was broken After closing the public review opportunity, clicking the Reviewer Count down stepper could leave a hidden blank additional member slot in form state and the Work app could become unresponsive. Root cause (if identifiable) The prior follow-up unregistered hidden blank additional member fields but returned before clearing the parent additionalMemberIds value. React Hook Form could keep the stale blank array value watched by the reviewer cleanup effect, allowing that cleanup path to run repeatedly. What was changed The reviewer-count shrink cleanup now always writes the trimmed additionalMemberIds value back to the form so hidden blank slots are removed from state. Resource deletion remains gated to cases where an actual assigned member id was removed. Any added/updated tests Updated the HumanReviewTab regression to follow QA's public-opportunity toggle path, decrease the reviewer count, assert the hidden blank slot is cleared from form state, and confirm no reviewer resource deletion is attempted for blank slots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
After closing the public review opportunity, clicking the Reviewer Count down stepper could leave a hidden blank additional member slot in form state and the Work app could become unresponsive.
Root cause (if identifiable)
The prior follow-up unregistered hidden blank additional member fields but returned before clearing the parent additionalMemberIds value. React Hook Form could keep the stale blank array value watched by the reviewer cleanup effect, allowing that cleanup path to run repeatedly.
What was changed
The reviewer-count shrink cleanup now always writes the trimmed additionalMemberIds value back to the form so hidden blank slots are removed from state. Resource deletion remains gated to cases where an actual assigned member id was removed.
Any added/updated tests
Updated the HumanReviewTab regression to follow QA's public-opportunity toggle path, decrease the reviewer count, assert the hidden blank slot is cleared from form state, and confirm no reviewer resource deletion is attempted for blank slots.
Validation: