TCA-400 - update behavior for fcc sidebar (course outline navigation) #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testflyjets
approved these changes
Sep 7, 2022
brooketopcoder
suggested changes
Sep 7, 2022
Contributor
brooketopcoder
left a comment
brooketopcoder
left a comment
There was a problem hiding this comment.
Looks good. Just one comment...
| }, [props.isOpen]) | ||
|
|
||
| useEffect(() => { | ||
| const handleClickOutside: (ev: MouseEvent) => void = (ev: MouseEvent) => { |
Contributor
There was a problem hiding this comment.
I'd prefer we use the existing useClickOutside hook. Is there a reason we can't use it? If so, maybe we extend it to do what we need?
Collaborator
Author
There was a problem hiding this comment.
Hey @brooketopcoder ! yes, totally. I was looking for it but I didn't find it where I was searching. I replaced the code and looks much cleaner now. thanks!
brooketopcoder
approved these changes
Sep 7, 2022
Contributor
brooketopcoder
left a comment
brooketopcoder
left a comment
There was a problem hiding this comment.
Perfecto--thanks, @vas3a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/TCA-400
Toggle course outline in fcc page when: