Skip to content

Implements GAME-81 #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 20, 2022
Merged

Implements GAME-81 #293

merged 9 commits into from
Sep 20, 2022

Conversation

@kkartunov
Copy link
Collaborator

@kkartunov kkartunov commented Sep 12, 2022 •
edited
Loading

@testflyjets
Copy link
Contributor

testflyjets commented Sep 12, 2022

It's helpful to a reviewer to include a short description of what the PR includes, either via a link to the Jira story (if it's just a few), or if it's multiple tickets, a description of what it implements.

testflyjets
testflyjets reviewed Sep 12, 2022
View reviewed changes
Copy link
Contributor

@testflyjets testflyjets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment about code that's commented-out.

brooketopcoder
brooketopcoder suggested changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@brooketopcoder brooketopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @kkartunov ! Let me know if you have any questions.

@kkartunov
Copy link
Collaborator Author

kkartunov commented Sep 13, 2022 •
edited
Loading

It's helpful to a reviewer to include a short description of what the PR includes, either via a link to the Jira story (if it's just a few), or if it's multiple tickets, a description of what it implements.

@testflyjets added jira link in desc for more context.

@kkartunov
Copy link
Collaborator Author

kkartunov commented Sep 14, 2022 •
edited
Loading

@brooketopcoder @testflyjets I sugest we merge this upstream, if you agree updates implemented are good?

kkartunov and others added 5 commits September 19, 2022 14:00
@kkartunov
GAME-107 and GAME-99
40ef0de
@brooketopcoder
GAME-107 #comment This commit refactors the SWR to be a generic hook …
9f83312 
…that lives in the lib and can be re-used elsewhere. It makes the styling of the Load More button static. It moves everything to do w/routing to the .routes page and removes duplicate paths. It creates a breadccrumb provider for the Gamification tool so we're not duplicating the base item. It moves the retrieval of the badge info into a provider so that it's not directly in the presentation layer. #time 4h
@brooketopcoder
GAME-107 clean-up
95cefd1
@brooketopcoder
GAMe-107 clean up
5ac9f54
@kkartunov
Merge pull request #300 from topcoder-platform/GAME-107_bjcs
1eb9358 
GAME-107
@kkartunov
Copy link
Collaborator Author

kkartunov commented Sep 20, 2022

Merging this one as we covered all requirements with #300

@kkartunov kkartunov merged commit 1175617 into gamification Sep 20, 2022
@brooketopcoder brooketopcoder deleted the feat/GAME-81 branch September 20, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@testflyjets testflyjets testflyjets left review comments

@brooketopcoder brooketopcoder brooketopcoder requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kkartunov @testflyjets @brooketopcoder