GAME-107 #300
Merged
GAME-107 #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that lives in the lib and can be re-used elsewhere. It makes the styling of the Load More button static. It moves everything to do w/routing to the .routes page and removes duplicate paths. It creates a breadccrumb provider for the Gamification tool so we're not duplicating the base item. It moves the retrieval of the badge info into a provider so that it's not directly in the presentation layer. #time 4h
kkartunov
approved these changes
Sep 20, 2022
Collaborator
kkartunov
left a comment
kkartunov
left a comment
There was a problem hiding this comment.
Thank you for this PR @brooketopcoder!
Learned functional coding style from this great PR and feel happy to get more organized.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
refactors the SWR to be a generic hook that lives in the lib and can be re-used elsewhere.
moves the retrieval of the badge info into a provider so that it's not directly in the presentation layer.
makes the styling of the Load More button static.
moves everything to do w/routing to the .routes page and removes duplicate paths.
creates a breadcrumb provider for the Gamification tool so we're not duplicating the base item.
removes the center-header config property bc the Actions column doesn't require a heading bc its implied by the content cells.