TCA-955 short URLs support via completionUuid
#497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkartunov
commented
Feb 16, 2023
|
|
||
| export interface TCACertificationEnrollmentProviderData { | ||
| enrollment: TCACertificationProgress | undefined | ||
| enrollment: TCACertificationEnrollmentBase | TCACertificationProgress | undefined |
Collaborator
Author
There was a problem hiding this comment.
@vas3a please take a look at this.
The progress provider you wrote recently needs to be updatated to extend TCACertificationEnrollmentBase in tca-certification-progress.model.ts. It is misleading to call the progress - enrollment.
useTCACertificationEnrollment hook uses that interface thus I added the OR here but we need to remove TCACertificationProgress as there are some lint errors. Not breaking, just FYI.
Collaborator
There was a problem hiding this comment.
Hey @kkartunov ! TCACertificationEnrollmentProviderData is not used anymore. I need to remove it.
Collaborator
Author
There was a problem hiding this comment.
Okay, we good now. You can do so in some of your next PRs and clean up, thanks for checking.
vas3a
approved these changes
Feb 16, 2023
testflyjets
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
completionUuidfor the hirinmg manager page