Skip to content

Conversation

@vikasrohit
Copy link

No description provided.

@vikasrohit
Copy link
Author

vikasrohit commented Dec 20, 2017

@vic-topcoder @mtwomey @dmessing @sachin-maheshwari Merging this PR. The risk with merging this PR is that if we make any production release (hotfix or normal), without merging topcoder-archive/connect-app#1490 in the deployed branch, it would break things as things that connect-app is expecting are no longer in react-components without topcoder-archive/connect-app#1490 being merged.
I am hoping that we are not going to do any production release before our scheduled release tomorrow.
Fallback: If we have to make a release without topcoder-archive/connect-app#1490 being merged, we have to reverse merge these changes before that deploy.

@vikasrohit vikasrohit merged commit ac2f6c5 into feature/connectv2 Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants