PM-1110 - sfdc payment report #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmgasper
requested changes
Sep 1, 2025
There was a problem hiding this comment.
@vas3a - This looks really good, thanks for the cleanup. Just one request - can we move the SQL to a separate file like it is for the sample reports I added please?
My thinking there is that it is easier to track down the SQL and run it manually for debugging, if the SQL is stored in separate files instead of embedded in code. I've had to do a lot of debugging with the current report structure, and having the SQL inline is quite a surprising headache.
|
@jmgasper done, can you check it out? |
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PM-1110 - Report for payment load, to be used by SFDC
Added endpoint for SFDC payments report.
Moved current reports module to topgear-reports module.