Conversation
What was broken Marathon Match challenge exports in the new challenge reports only exposed provisionalScore and finalRank. When a challenge only had final review scores for some members, those rows exported with blank score cells and no finalScore column even though the ranking logic already had access to final scores. Root cause (if identifiable) The earlier PM-4151 follow-up on develop reshaped Marathon Match rows to publish only provisionalScore and finalRank. The SQL still loaded final review scores for effective ranking, but the report queries and formatter never projected finalScore into the exported record shape. What was changed Added finalScore to the Marathon Match challenge report DTO and formatter output. Updated the submitters, valid-submitters, and winners SQL to emit rounded finalScore values while preserving the existing effective-rank ordering and tie-break behavior. Updated the challenge report catalog descriptions to document provisionalScore and finalScore availability. Aligned the new challenge report regression spec with the current develop branch export shape, including firstName and lastName fields. Included the repo lint auto-format on one existing conditional in topcoder-reports.service.ts. Any added/updated tests Added ChallengesReportsService regression tests covering Marathon Match submitter and winner exports plus the unchanged standard challenge submissionScore shape on the current export record format. Verified pnpm lint, the new challenge report spec, and pnpm build on this branch. The repo-wide pnpm test command still fails in unrelated pre-existing SFDC specs on the current develop base.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Marathon Match challenge exports in the new challenge reports only exposed provisionalScore and finalRank. When a challenge only had final review scores for some members, those rows exported with blank score cells and no finalScore column even though the ranking logic already had access to final scores.
Root cause (if identifiable)
The earlier PM-4151 follow-up on develop reshaped Marathon Match rows to publish only provisionalScore and finalRank. The SQL still loaded final review scores for effective ranking, but the report queries and formatter never projected finalScore into the exported record shape.
What was changed
Added finalScore to the Marathon Match challenge report DTO and formatter output.
Updated the submitters, valid-submitters, and winners SQL to emit rounded finalScore values while preserving the existing effective-rank ordering and tie-break behavior.
Updated the challenge report catalog descriptions to document provisionalScore and finalScore availability.
Aligned the new challenge report regression spec with the current develop branch export shape, including firstName and lastName fields.
Included the repo lint auto-format on one existing conditional in topcoder-reports.service.ts.
Any added/updated tests
Added ChallengesReportsService regression tests covering Marathon Match submitter and winner exports plus the unchanged standard challenge submissionScore shape on the current export record format.
Verified pnpm lint, the new challenge report spec, and pnpm build on this branch.
The repo-wide pnpm test command still fails in unrelated pre-existing SFDC specs on the current develop base.