Conversation
What was broken The PM-4151 challenge export regression spec on current develop still asserted the older export shape without firstName and lastName, so the focused challenge report test failed even though the Marathon Match finalScore export fix had already been merged. Root cause (if identifiable) The earlier follow-up branch updated the regression spec for the current export shape, but that spec change never landed on top of the develop branch after firstName and lastName were added to challenge user exports. What was changed Updated the challenge report regression fixtures and expectations to include firstName and lastName for Marathon Match and standard challenge exports. Kept the follow-up scoped to the regression coverage only because the functional MM finalScore export fix is already present on develop. Any added/updated tests Updated src/reports/challenges/challenges-reports.service.spec.ts to assert the current export columns. Verified pnpm lint, pnpm test --runInBand src/reports/challenges/challenges-reports.service.spec.ts, and pnpm build on this branch. The full pnpm test --runInBand suite still fails in unrelated pre-existing SFDC specs on the current develop base.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The PM-4151 challenge export regression spec on current develop still asserted the older export shape without firstName and lastName, so the focused challenge report test failed even though the Marathon Match finalScore export fix from PR #69 had already been merged.
Root cause (if identifiable)
The earlier follow-up branch updated the regression spec for the current export shape, but that spec change never landed on top of develop after firstName and lastName were added to challenge user exports.
What was changed
Updated the challenge report regression fixtures and expectations to include firstName and lastName for Marathon Match and standard challenge exports.
Kept the follow-up scoped to the regression coverage only because the functional MM finalScore export fix is already present on develop.
Any added/updated tests
Updated src/reports/challenges/challenges-reports.service.spec.ts to assert the current export columns.
Verified pnpm lint, pnpm test --runInBand src/reports/challenges/challenges-reports.service.spec.ts, and pnpm build on this branch.
The full pnpm test --runInBand suite still fails in unrelated pre-existing SFDC specs on the current develop base.