Conversation
What was broken Reports app CSV downloads for SFDC reports, including Payments, saved JSON response bodies into .csv files. Root cause The SFDC reports controller did not use the existing CSV response interceptor, so Accept: text/csv requests still returned the controller data as JSON. What was changed Enabled application/json and text/csv production on the SFDC reports controller, attached the existing CsvResponseInterceptor, and registered the CSV serializer/interceptor providers in the SFDC reports module. Any added/updated tests Added SFDC controller and module coverage for CSV interceptor wiring. Updated the BA fees optional groupBy assertion to accept an omitted optional property while still verifying the value is undefined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Reports app CSV downloads for SFDC reports, including Payments, saved JSON response bodies into .csv files.
Root cause
The SFDC reports controller did not use the existing CSV response interceptor, so Accept: text/csv requests still returned the controller data as JSON.
What was changed
Enabled application/json and text/csv production on the SFDC reports controller, attached the existing CsvResponseInterceptor, and registered the CSV serializer/interceptor providers in the SFDC reports module.
Any added/updated tests
Added SFDC controller and module coverage for CSV interceptor wiring. Updated the BA fees optional groupBy assertion to accept an omitted optional property while still verifying the value is undefined.
Focused SFDC tests, changed-file ESLint, and build passed. The full test suite was run and still fails on existing unrelated SFDC DTO validation, TaaS empty-array, and member-search SQL assertion failures from the current develop baseline.