new filter for RB #411
Merged
new filter for RB #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
suggested changes
Jul 20, 2021
Contributor
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
thanks, @eisbilir filtering works great.
There is just one typo in the error message. If I only filter by workPeriods.isLastWeek=true I get error "Cannot set \"isFirstWeek\" without \"startDate\"", though it suppose to be isLastWeek and endDate in the error message.
Also, there are a few suggestions on how to rephrase validation messages below.
eisbilir
commented
Jul 20, 2021
Member
Author
eisbilir
left a comment
eisbilir
left a comment
There was a problem hiding this comment.
- workPeriods.isFirstWeek - should only return RB if the week which matches workPeriods.startDate is the first one in the RB
- workPeriods.isLastWeek - should only return RB if the week which matches workPeriods.startDate is the last one in the RB
according to there, we match with startDate for both workPeriods.isFirstWeek and workPeriods.isLastWeek
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.