fix: script to import job from RCRM #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
suggested changes
Jul 29, 2021
Contributor
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
@eisbilir it works perfectly.
Though as per diff it looks like files were completely updated, even though only small parts of them were updated. I guess it is because inside these files line endings have been changed from LF to CRLF.
Is it possible to bring back LF line endings to the files, so in diff we would only see the real changes? This would be also good for consistency, as inside the repo we usually use LF line endings.
Demo video https://monosnap.com/file/nC9oyKqQnXPpVhoyd83HbdPLDAxzKj
eisbilir
force-pushed
the
fix/job-import-script
branch
from
86b1b7c to
60d476e
Compare
maxceem
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.