Skip to content

Conversation

@eisbilir
Copy link
Member

@eisbilir eisbilir commented Aug 1, 2021

No description provided.

@eisbilir eisbilir requested a review from maxceem August 1, 2021 14:37
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eisbilir I've noticed in Swagger request for bulk update suppose to be array while now it's one object:

image

Otherwise works great.

@eisbilir eisbilir requested a review from maxceem August 2, 2021 07:54
@eisbilir
Copy link
Member Author

eisbilir commented Aug 2, 2021

@maxceem I've changed the calculation of maxPossibleDays when updating WPP here: https://github.com/topcoder-platform/taas-apis/pull/438/files#diff-804e247f8b86363db6fdd74bb6494b367edb28133e2a794ffe988522db7d3fd2R286-R287
If you didn't notice, I need you to double check if it's correct now.

@maxceem
Copy link
Contributor

maxceem commented Aug 2, 2021

I've changed the calculation of maxPossibleDays when updating WPP here: https://github.com/topcoder-platform/taas-apis/pull/438/files#diff-804e247f8b86363db6fdd74bb6494b367edb28133e2a794ffe988522db7d3fd2R286-R287

@eisbilir great catch! Thanks for fixing that.

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eisbilir all is perfect now.

@maxceem maxceem merged commit e5d8118 into topcoder-platform:dev Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants