Skip to content

fix(role-service): update validations to accept positive integers #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2021
Merged

fix(role-service): update validations to accept positive integers #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bootstrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Joi.workPeriodPaymentUpdateStatus = () => Joi.string().valid(..._.values(WorkPer
// See https://joi.dev/api/?v=17.3.0#string fro details why it's like this.
// In many cases we would like to allow empty string to make it easier to create UI for editing data.
Joi.stringAllowEmpty = () => Joi.string().allow('')
Joi.smallint = () => Joi.number().min(-32768).max(32767)
Joi.smallint = () => Joi.number().integer().min(-32768).max(32767)

function buildServices (dir) {
const files = fs.readdirSync(dir)
Expand Down
64 changes: 32 additions & 32 deletions src/services/RoleService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,24 +131,24 @@ createRole.schema = Joi.object().keys({
description: Joi.string().max(1000),
listOfSkills: Joi.array().items(Joi.string().max(50).required()),
rates: Joi.array().items(Joi.object().keys({
global: Joi.smallint(),
inCountry: Joi.smallint(),
offShore: Joi.smallint(),
niche: Joi.smallint(),
rate30Niche: Joi.smallint(),
rate30Global: Joi.smallint(),
rate30InCountry: Joi.smallint(),
rate30OffShore: Joi.smallint(),
rate20Niche: Joi.smallint(),
rate20Global: Joi.smallint(),
rate20InCountry: Joi.smallint(),
rate20OffShore: Joi.smallint()
global: Joi.smallint().min(1),
inCountry: Joi.smallint().min(1),
offShore: Joi.smallint().min(1),
niche: Joi.smallint().min(1),
rate30Niche: Joi.smallint().min(1),
rate30Global: Joi.smallint().min(1),
rate30InCountry: Joi.smallint().min(1),
rate30OffShore: Joi.smallint().min(1),
rate20Niche: Joi.smallint().min(1),
rate20Global: Joi.smallint().min(1),
rate20InCountry: Joi.smallint().min(1),
rate20OffShore: Joi.smallint().min(1)
}).required()).required(),
numberOfMembers: Joi.number(),
numberOfMembersAvailable: Joi.smallint(),
numberOfMembers: Joi.number().integer().min(1),
numberOfMembersAvailable: Joi.smallint().min(1),
imageUrl: Joi.string().uri().max(255),
timeToCandidate: Joi.smallint(),
timeToInterview: Joi.smallint()
timeToCandidate: Joi.smallint().min(1),
timeToInterview: Joi.smallint().min(1)
}).required()
}).required()

Expand Down Expand Up @@ -189,24 +189,24 @@ updateRole.schema = Joi.object().keys({
description: Joi.string().max(1000).allow(null),
listOfSkills: Joi.array().items(Joi.string().max(50).required()).allow(null),
rates: Joi.array().items(Joi.object().keys({
global: Joi.smallint().required(),
inCountry: Joi.smallint().required(),
offShore: Joi.smallint().required(),
niche: Joi.smallint(),
rate30Niche: Joi.smallint(),
rate30Global: Joi.smallint(),
rate30InCountry: Joi.smallint(),
rate30OffShore: Joi.smallint(),
rate20Global: Joi.smallint(),
rate20Niche: Joi.smallint(),
rate20InCountry: Joi.smallint(),
rate20OffShore: Joi.smallint()
global: Joi.smallint().min(1).required(),
inCountry: Joi.smallint().min(1).required(),
offShore: Joi.smallint().min(1).required(),
niche: Joi.smallint().min(1),
rate30Niche: Joi.smallint().min(1),
rate30Global: Joi.smallint().min(1),
rate30InCountry: Joi.smallint().min(1),
rate30OffShore: Joi.smallint().min(1),
rate20Global: Joi.smallint().min(1),
rate20Niche: Joi.smallint().min(1),
rate20InCountry: Joi.smallint().min(1),
rate20OffShore: Joi.smallint().min(1)
}).required()),
numberOfMembers: Joi.number().allow(null),
numberOfMembersAvailable: Joi.smallint().allow(null),
numberOfMembers: Joi.number().integer().min(1).allow(null),
numberOfMembersAvailable: Joi.smallint().min(1).allow(null),
imageUrl: Joi.string().uri().max(255).allow(null),
timeToCandidate: Joi.smallint().allow(null),
timeToInterview: Joi.smallint().allow(null)
timeToCandidate: Joi.smallint().min(1).allow(null),
timeToInterview: Joi.smallint().min(1).allow(null)
}).required()
}).required()

Expand Down