Skip to content

[DEV][HOTFIX] Send survey for workperiods #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 9, 2021
Merged

[DEV][HOTFIX] Send survey for workperiods #459

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c31d278
Merge pull request #407 from topcoder-platform/dev
urwithat Jul 26, 2021
5d02723
Merge pull request #439 from topcoder-platform/dev
nkumar-topcoder Aug 9, 2021
20b4d7d
fix send survey for work periods
maxceem Aug 9, 2021
feb14c0
use "of" instead of "in" to be sure
maxceem Aug 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 11 additions & 17 deletions src/services/SurveyService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ const { getUserById, getMemberDetailsByHandle } = require('../common/helper')
const { getCollectorName, createCollector, createMessage, upsertContactInSurveyMonkey, addContactsToSurvey, sendSurveyAPI } = require('../common/surveyMonkey')

const resourceBookingCache = {}
const contactIdToWorkPeriodIdMap = {}
const emailToWorkPeriodIdMap = {}

function buildSentSurveyError (e) {
return {
Expand Down Expand Up @@ -62,15 +60,16 @@ async function sendSurveys () {
const collectorId = await createCollector(collectorName)
const messageId = await createMessage(collectorId)
// create map
contactIdToWorkPeriodIdMap[collectorName] = {}
emailToWorkPeriodIdMap[collectorName] = {}
collectors[collectorName] = {
workPeriodIds: [],
collectorId,
messageId,
contacts: []
}
}

collectors[collectorName].workPeriodIds.push(workPeriod.id)

const resourceBooking = _.find(resourceBookings, (r) => r.id === workPeriod.resourceBookingId)
const userInfo = {}
if (!resourceBookingCache[resourceBooking.userId]) {
Expand All @@ -89,7 +88,6 @@ async function sendSurveys () {
resourceBookingCache[resourceBooking.userId] = userInfo
}
}
emailToWorkPeriodIdMap[collectorName][resourceBookingCache[resourceBooking.userId].email] = workPeriod.id
collectors[collectorName].contacts.push(resourceBookingCache[resourceBooking.userId])
} catch (e) {
try {
Expand All @@ -105,17 +103,13 @@ async function sendSurveys () {
}

// add contacts
for (const collectorName in collectors) {
for (const collectorName of _.keys(collectors)) {
const collector = collectors[collectorName]
collectors[collectorName].contacts = await upsertContactInSurveyMonkey(collector.contacts)

for (const contact of collectors[collectorName].contacts) {
contactIdToWorkPeriodIdMap[collectorName][contact.id] = emailToWorkPeriodIdMap[collectorName][contact.email]
}
}

// send surveys
for (const collectorName in collectors) {
for (const collectorName of _.keys(collectors)) {
const collector = collectors[collectorName]
if (collector.contacts.length) {
try {
Expand All @@ -125,23 +119,23 @@ async function sendSurveys () {
collector.contacts
)
await sendSurveyAPI(collector.collectorId, collector.messageId)
for (const contactId in contactIdToWorkPeriodIdMap[collectorName]) {
for (const workPeriodId of collectors[collectorName].workPeriodIds) {
try {
await partiallyUpdateWorkPeriod(currentUser, contactIdToWorkPeriodIdMap[collectorName][contactId], { sentSurvey: true })
await partiallyUpdateWorkPeriod(currentUser, workPeriodId, { sentSurvey: true })
} catch (e) {
logger.error({ component: 'SurveyService', context: 'sendSurvey', message: `Error updating survey as sent for Work Period "${contactIdToWorkPeriodIdMap[collectorName][contactId]}": ` + e.message })
logger.error({ component: 'SurveyService', context: 'sendSurvey', message: `Error updating survey as sent for Work Period "${workPeriodId}": ` + e.message })
}
}
} catch (e) {
for (const contactId in contactIdToWorkPeriodIdMap[collectorName]) {
for (const workPeriodId of collectors[collectorName].workPeriodIds) {
try {
await partiallyUpdateWorkPeriod(
currentUser,
contactIdToWorkPeriodIdMap[collectorName][contactId],
workPeriodId,
{ sentSurveyError: buildSentSurveyError(e) }
)
} catch (e) {
logger.error({ component: 'SurveyService', context: 'sendSurvey', message: `Error updating survey as failed for Work Period "${contactIdToWorkPeriodIdMap[collectorName][contactId]}": ` + e.message })
logger.error({ component: 'SurveyService', context: 'sendSurvey', message: `Error updating survey as failed for Work Period "${workPeriodId}": ` + e.message })
}
}
}
Expand Down