Skip to content

Hotfix/removing beta api url #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 8, 2021
Merged

Hotfix/removing beta api url #533

merged 6 commits into from
Sep 8, 2021

Conversation

@vikasrohit
Copy link

@vikasrohit vikasrohit commented Sep 2, 2021

Dev version

@vikasrohit
Copy link
Author

vikasrohit commented Sep 2, 2021

@nkumar-topcoder @sachin-maheshwari I have kept TC_BETA_API in env config file for future purposes. I mean whenever we want to use a beta endpoint for a transition like we did for Skills API, we can leverage that env variable. Let me know if you guys think, it does not worth it. fyi @mtwomey

@vikasrohit vikasrohit merged commit 7b95462 into dev Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nkumar-topcoder nkumar-topcoder Awaiting requested review from nkumar-topcoder

@sachin-maheshwari sachin-maheshwari Awaiting requested review from sachin-maheshwari

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vikasrohit @nkumar-topcoder @urwithat