-
Notifications
You must be signed in to change notification settings - Fork 32
fix: issue #615 #650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue #615 #650
Conversation
| */ | ||
| function buildProjectTeamRecipients (project) { | ||
| const recipients = _.unionBy(_.map(project.members, m => _.pick(m, 'userId')), 'userId') | ||
| const recipients = _.unionBy(_.map(project.members, m => _.pick(m, 'email')), 'email') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoution Emails could be sent by userId. I'm not sure that project members would always have email addresses. Can we keep userId here, or this breaks something?
|
@yoution I hardcode the lines as you suggested, and run TaaS API from scratch including So it doesn't work for me as per local testing. |
|
@yoution I've tested by hardcoding other users and it seems to work good for me localy I'm merging this PR for QA. But could you please let me know if we can revert the change for Project members above? #650 (review) |
maxceem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoution merging for QA.
|
@maxceem I will revert to |
|
@yoution already merged :-), could you please create a new PR with reverted change. |
|
@yoution thanks, merged. |
@maxceem please review;
for testing locally, can you hardcode the id?
hardcode the file
src/services/NotificationsSchedulerService.jsline 36, hardcode the
projectIdline 115 and line 116, hardcode the
uuid