PM-2561 skip payments for reward challenges #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| const paymentTypes = [ | ||
| ...new Set( |
There was a problem hiding this comment.
[performance]
Using new Set followed by spreading into an array is a common pattern for deduplication, but it might be more efficient to use a single reduce operation to build the array directly without intermediate structures. Consider using reduce to accumulate unique payment types.
| .flat(), | ||
| ), | ||
| ]; | ||
| const isRewardsPayment = paymentTypes.some((type) => type !== 'USD'); |
There was a problem hiding this comment.
[❗❗ correctness]
The variable isRewardsPayment is determined by checking if any payment type is not 'USD'. This logic might be misleading if there are mixed types (e.g., both 'USD' and another type). Ensure that the logic aligns with the intended business rule.
kkartunov
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PM-2561
based on slack discussion, points challenges are handled on topgear's side. skipping payments creation completely for other types of prizes (other than USD)