Skip to content

PM-2561 skip payments for reward challenges #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
Merged

PM-2561 skip payments for reward challenges #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8669b20
make sure to return error message
vas3a Oct 27, 2025
8e5835f
PM-2561 - for challenges with prize sets other than USD, skip payment…
vas3a Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/api/challenges/challenges.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ export class ChallengesController {
);
result.status = ResponseStatusType.SUCCESS;
} catch (e) {
result.error = e;
result.error = {
...e,
message: e.message,
};
result.status = ResponseStatusType.ERROR;
}

Expand Down
16 changes: 16 additions & 0 deletions src/api/challenges/challenges.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,22 @@ export class ChallengesService {
);
}

const paymentTypes = [
...new Set(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ performance]
Using new Set followed by spreading into an array is a common pattern for deduplication, but it might be more efficient to use a single reduce operation to build the array directly without intermediate structures. Consider using reduce to accumulate unique payment types.

challenge.prizeSets
.map((set) => set.prizes.map((prize) => prize.type))
.flat(),
),
];
const isRewardsPayment = paymentTypes.some((type) => type !== 'USD');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
The variable isRewardsPayment is determined by checking if any payment type is not 'USD'. This logic might be misleading if there are mixed types (e.g., both 'USD' and another type). Ensure that the logic aligns with the intended business rule.


if (isRewardsPayment) {
this.logger.log(
`Rewards system detected: ${paymentTypes.join(', ')}. Skipping payments generation for challenge ${challenge.name} (${challenge.id}).`,
);
return;
}

const payments = await this.getChallengePayments(challenge);
const totalAmount = payments.reduce(
(sum, payment) => sum + payment.details[0].totalAmount,
Expand Down