Skip to content

[Hotfix PROD] - duplicated payments #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 22, 2025
Merged

[Hotfix PROD] - duplicated payments #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
59c1e09
Remove any reference to rewards
vas3a Oct 22, 2025
8fb4c09
Merge pull request #94 from topcoder-platform/remove-rewards-deps
vas3a Oct 22, 2025
94461a5
When withdrawing, do not use transaction, as this can cause issues if…
vas3a Oct 22, 2025
bce5825
Merge pull request #95 from topcoder-platform/hotfix-drop-transaction…
kkartunov Oct 22, 2025
42749c6
Remove payment if error is thrown when db data is updated
vas3a Oct 22, 2025
b41c474
Merge pull request #97 from topcoder-platform/hotfix-drop-transaction…
kkartunov Oct 22, 2025
bf2fd8d
lock otp db row
vas3a Oct 22, 2025
95e072d
add missing method
vas3a Oct 22, 2025
ac81770
Merge pull request #98 from topcoder-platform/hotfix-drop-transaction…
vas3a Oct 22, 2025
120fbc5
Merge pull request #99 from topcoder-platform/hotfix-drop-transaction…
vas3a Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions src/api/wallet/wallet.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,6 @@ export class WalletService {
),
unit: 'currency',
},
// hide rewards for now
// {
// type: WinningsType.REWARD,
// amount: rewardTotal,
// unit: 'points',
// },
],
},
withdrawalMethod: {
Expand Down Expand Up @@ -118,7 +112,7 @@ export class WalletService {

getWinningsTotalsByWinnerID(winnerId: string) {
return this.prisma.$queryRaw<
{ payment_type: 'PAYMENT' | 'REWARD'; total_owed: number }[]
{ payment_type: 'PAYMENT'; total_owed: number }[]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
The removal of 'REWARD' from the payment_type union may impact the correctness of the query results if REWARD payments are still relevant to the business logic. Ensure that this change aligns with the intended functionality and that REWARD payments are handled appropriately elsewhere if needed.

>`
WITH latest_payment_version AS (
SELECT
Expand All @@ -133,7 +127,6 @@ export class WalletService {
w.type AS payment_type,
CASE
WHEN w.type = 'PAYMENT' THEN SUM(p.total_amount)
WHEN w.type = 'REWARD' THEN SUM(r.points)
ELSE 0
END AS total_owed
FROM
Expand All @@ -144,8 +137,6 @@ export class WalletService {
AND p.installment_number = 1
INNER JOIN latest_payment_version lpv ON p.winnings_id = lpv.winnings_id
AND p.version = lpv.max_version
LEFT JOIN reward r ON w.winning_id = r.winnings_id
AND w.type = 'REWARD'
WHERE
w.winner_id = ${winnerId}
GROUP BY
Expand Down
Loading