Remove payment if error is thrown when db data is updated #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } catch (e) { | ||
| this.logger.error( | ||
| `Failed to update payment processing state: ${e.message} for winnings '${winningsIds.join(',')}`, | ||
| `Failed to update payment processing state: ${e?.message} for winnings '${winningsIds.join(',')}`, |
There was a problem hiding this comment.
[correctness]
Using optional chaining (e?.message) is a good practice to avoid runtime errors if e is null or undefined. However, ensure that e is always an object in this context. If e can be a non-object type, consider adding a type guard or additional error handling to ensure that e.message is accessed safely.
| status: 'FAILED', | ||
| }); | ||
|
|
||
| await this.trolleyService.removePayment( |
There was a problem hiding this comment.
[❗❗ correctness]
Consider wrapping the removePayment call in a try-catch block to handle potential errors gracefully. If removePayment fails, it could leave the system in an inconsistent state, especially since an error is already being thrown immediately after.
kkartunov
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.