Skip to content

Hotfix/adding quantity field project estimations #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2019
Merged

Hotfix/adding quantity field project estimations #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb1f7d7
Merge pull request #308 from topcoder-platform/dev
RishiRajSahu Jun 4, 2019
d33834a
Added quantity field for project estimations as we need to store quan…
Jun 4, 2019
32ccec7
Added quantity field to the route request validation
Jun 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions migrations/20190604_project_estimation_add_quantity.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
--
-- UPDATE EXISTING TABLES:
-- project_estimations:
-- added column `quantity`

--
-- product_templates

-- Add new column
ALTER TABLE project_estimations ADD COLUMN "quantity" int DEFAULT 1;
1 change: 1 addition & 0 deletions src/models/projectEstimation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ module.exports = function defineProjectHistory(sequelize, DataTypes) {
buildingBlockKey: { type: DataTypes.STRING, allowNull: false },
conditions: { type: DataTypes.STRING, allowNull: false },
price: { type: DataTypes.DOUBLE, allowNull: false },
quantity: { type: DataTypes.INTEGER, allowNull: true },
minTime: { type: DataTypes.INTEGER, allowNull: false },
maxTime: { type: DataTypes.INTEGER, allowNull: false },
metadata: { type: DataTypes.JSON, allowNull: false, defaultValue: {} },
Expand Down
1 change: 1 addition & 0 deletions src/routes/projects/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ const createProjectValdiations = {
estimation: Joi.array().items(Joi.object().keys({
conditions: Joi.string().required(),
price: Joi.number().required(),
quantity: Joi.number().optional(),
minTime: Joi.number().integer().required(),
maxTime: Joi.number().integer().required(),
buildingBlockKey: Joi.string().required(),
Expand Down