fix project terms load and default terms in beta #1059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
suggested changes
Jan 27, 2021
Contributor
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
Thanks for the quick update @CDharmateja.
Generally, it works good now. But it has one drawback. One the EDIT/VIEW pages, project details are now loaded twice
We have to load them only one time per page.
maxceem
suggested changes
Jan 27, 2021
Contributor
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
@CDharmateja beta flag works good.
But on EDIT/VIEW page the project details are still loaded twice:
This can be seen if you load any EDIT/VIEW page by direct link http://localhost:3000/projects/16942/challenges/8b2b38a3-c806-4641-98f3-f3dc06b1c9bf/edit
maxceem
approved these changes
Jan 28, 2021
Contributor
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
Thanks, @CDharmateja works good now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1044