fix: issue 1071 #1094
Merged
fix: issue 1071 #1094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
suggested changes
Mar 3, 2021
Contributor
maxceem
left a comment
maxceem
left a comment
There was a problem hiding this comment.
@narekcat great finding.
It works good, just would like to improve one moment. Currenlty, when we select user the width of the field jumps, see demo video https://monosnap.com/file/BvqGuMNIyLfJG2ytnsELQaKPFnKxQM
Can we fix it so it doesn't jump when we select the user or clear it?
Another thing, could you please pull the latest changes from develop branch. Your fix is done for some outdated version, just to make sure it works good with the latest code we have in the develop branch now.
Thanks
Contributor
Author
|
Hi @maxceem . I'll fix both issues and update pull request. |
Contributor
Author
|
@maxceem . I have updated pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.