Skip to content

porting v8 pxCore main modules #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmgasper merged 3 commits into from
Jun 28, 2018
Merged

porting v8 pxCore main modules #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
894dbdf
porting core modules, working about.js
krunt Jun 28, 2018
0887489
fixes for linux
Jun 28, 2018
5b69596
fixes on mac
Jun 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cmake/V8Deps.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

set(NODEDIR "${EXTDIR}/libnode-v6.9.0/")
set(V8_INCLUDE_DIRS ${NODEDIR}/src ${NODEDIR}/deps/uv/include ${NODEDIR}/deps/v8/include ${NODEDIR}/deps/cares/include)

Expand All @@ -23,8 +22,10 @@ if (WIN32)
)
elseif (APPLE)
set(V8_LIBRARY_DIRS ${NODEDIR})
set (V8_INCLUDE_DIRS ${V8_INCLUDE_DIRS} ${NODEDIR}/deps/icu-small/source/common/)
set(V8_LIBRARIES node)
else ()
set (V8_INCLUDE_DIRS ${V8_INCLUDE_DIRS} ${NODEDIR}/deps/icu-small/source/common/)
set(V8_LIBRARY_DIRS
${NODEDIR}/out/Release/obj.target
${NODEDIR}/out/Release/obj.target/deps/v8_inspector/third_party/v8_inspector/platform/v8_inspector
Expand All @@ -47,9 +48,9 @@ else ()
zlib
http_parser
icustubdata
icui18n
icuucx
icudata
icuucx
icui18n
)
endif ()

Expand Down
2 changes: 1 addition & 1 deletion examples/pxScene2d/external/libnode-v6.9.0/buildNode.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
./configure --shared
make
make -j
ln -sf libnode.so.48 out/Release/obj.target/libnode.so
ln -sf libnode.48.dylib out/Release/libnode.dylib
Loading