Skip to content

added v8-build check #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmgasper merged 1 commit into from
Jul 17, 2018
Merged

added v8-build check #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions cmake/V8Deps.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,19 @@ set(V8_INCLUDE_DIRS ${V8DIR}/include
${NODEDIR}/deps/icu-small/source/common)

if (WIN32)
set(V8_LIBRARY_DIRS ${V8DIR}/out.gn/ia32.release ${NODEDIR}build/Release/lib ${NODEDIR}Release/lib ${NODEDIR}Release)
set(V8_LIBDIR ${V8DIR}/out.gn/ia32.release)
set(V8_LIBRARY_DIRS ${V8_LIBDIR} ${NODEDIR}build/Release/lib ${NODEDIR}Release/lib ${NODEDIR}Release)
set(V8_LIBRARIES
v8.dll.lib v8_libbase.dll.lib v8_libplatform.dll.lib
icutools.lib icustubdata.lib icudata.lib icuucx.lib icui18n.lib
winmm.lib dbghelp.lib shlwapi.lib
libuv.lib openssl.lib)
set(V8_BUILD_PATH_CHECK ${V8_LIBDIR}/v8.dll.lib)
elseif (APPLE)
set(V8_LIBDIR ${V8DIR}/out.gn/x64.release/obj)
set (V8_INCLUDE_DIRS ${V8_INCLUDE_DIRS} ${NODEDIR}/deps/icu-small/source/common/)
set(V8_LIBRARY_DIRS
${V8DIR}/out.gn/x64.release/obj
${V8_LIBDIR}
${NODEDIR})
set(V8_LIBRARIES
v8_base
Expand All @@ -26,10 +29,12 @@ elseif (APPLE)
v8_libsampler
v8_libbase
node)
set(V8_BUILD_PATH_CHECK ${V8_LIBDIR}/libv8_base.a)
else ()
set(V8_LIBDIR ${V8DIR}/out.gn/x64.release/obj)
set (V8_INCLUDE_DIRS ${V8_INCLUDE_DIRS} ${NODEDIR}/deps/icu-small/source/common/)
set(V8_LIBRARY_DIRS
${V8DIR}/out.gn/x64.release/obj
${V8_LIBDIR}
${NODEDIR}/out/Release/obj.target
${NODEDIR}/out/Release/obj.target/deps/uv
${NODEDIR}/out/Release/obj.target/deps/v8/tools/gyp
Expand All @@ -53,10 +58,17 @@ else ()
icuucx
icui18n
)
set(V8_BUILD_PATH_CHECK ${V8_LIBDIR}/libv8_base.a)
endif ()

if (NOT SUPPORT_V8)
if (SUPPORT_V8)
if(EXISTS ${V8_BUILD_PATH_CHECK})
message("external/v8 library is built successfully")
else ()
message(FATAL_ERROR "external/v8 library is not built, please build it first")
endif ()
else (SUPPORT_V8)
unset(V8_INCLUDE_DIRS)
unset(V8_LIBRARY_DIRS)
unset(V8_LIBRARIES)
endif (NOT SUPPORT_V8)
endif (SUPPORT_V8)