LintRoller plugin, rather than Inject monkey-patch#160
Merged
AlfonsoUceda merged 3 commits intomasterfrom Mar 30, 2026
Merged
Conversation
AlfonsoUceda
changed the title
AlfonsoUceda
force-pushed
the
pf-rubocop-pluginfy
branch
from
ecdcdf9 to
e2c2cee
Compare
RuboCop 1.72+ supports a formal plugin system via LintRoller::Plugin. This replaces the old Inject.defaults! approach that monkey-patched ConfigLoader with a proper Plugin class that declares its config through the LintRoller API. - Add lib/rubocop/granite/plugin.rb - Remove lib/rubocop/granite/inject.rb - Bump minimum rubocop to >= 1.72.1 - Add lint_roller ~> 1.1 dependency - Add default_lint_roller_plugin gemspec metadata - Update README to use plugins: instead of require:
AlfonsoUceda
force-pushed
the
pf-rubocop-pluginfy
branch
from
e2c2cee to
af7fed6
Compare
Renamed for consistency with rubocop-toptal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RuboCop 1.72+ introduced a formal plugin system via
LintRoller::Plugin, replacing the need to monkey-patchConfigLoaderto inject default configuration. This PR migrates rubocop-granite from the legacyInject.defaults!pattern to the new plugin API, following the approach taken by rubocop-toptal#53.Injectmodule removed, replaced byRuboCop::Granite::Pluginclass>= 1.72.1,lint_roller ~> 1.1addeddefault_lint_roller_plugingemspec metadata registeredplugins:instead ofrequire:Users should use
plugins: rubocop-granitein their.rubocop.ymlinstead ofrequire: rubocop-granite.Review
Pre-merge checklist
master(if not - rebase it).