[BASE-57] Test visual regression lib#4
Closed
bytasv wants to merge 1 commit into
Closed
Conversation
ruslan-sed
added a commit
that referenced
this pull request
Jun 12, 2024
ruslan-sed
added a commit
that referenced
this pull request
Jun 12, 2024
ruslan-sed
added a commit
that referenced
this pull request
Jun 12, 2024
ruslan-sed
added a commit
that referenced
this pull request
Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it's all in
Button/test.jsx(in a normal scenario we should keep it separate and under different task)Basically, this library allows doing "snapshots" just as we can do in jest. Right now you have to manually start storybook so it can visit the page, but later we could tie it to components documentation link.
Overall, I think it's quite a nice and easy solution, for now. I've tested changing CSS styles and it outputs visual diff as well as fails the build